Messages in this thread Patch in this message | | | Date | Tue, 8 Mar 2011 19:49:55 -0500 | From | "J. Bruce Fields" <> | Subject | Re: [PATCH] nfsd: wrong index used in inner loop |
| |
On Tue, Mar 08, 2011 at 10:32:26PM +0100, roel wrote: > Index i was already used in the outer loop > > Signed-off-by: Roel Kluin <roel.kluin@gmail.com> > --- > fs/nfsd/nfs4xdr.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > Not 100% sure this one is needed but it looks suspicious.
Looks bad to me, thanks.
nfsd4_decode_create_session should probably really be broken up a little bit; if it wasn't so long this would have been more obvious.
I'll see if I can slip this into 2.6.38 with a couple other last-minute patches.... Otherwise, it'll be in 2.6.39.
--b.
> > diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c > index 1275b86..615f0a9 100644 > --- a/fs/nfsd/nfs4xdr.c > +++ b/fs/nfsd/nfs4xdr.c > @@ -1142,7 +1142,7 @@ nfsd4_decode_create_session(struct nfsd4_compoundargs *argp, > > u32 dummy; > char *machine_name; > - int i; > + int i, j; > int nr_secflavs; > > READ_BUF(16); > @@ -1215,7 +1215,7 @@ nfsd4_decode_create_session(struct nfsd4_compoundargs *argp, > READ_BUF(4); > READ32(dummy); > READ_BUF(dummy * 4); > - for (i = 0; i < dummy; ++i) > + for (j = 0; j < dummy; ++j) > READ32(dummy); > break; > case RPC_AUTH_GSS:
| |