lkml.org 
[lkml]   [2011]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] mm: skip zombie in OOM-killer
    On Mon, 7 Mar 2011 12:36:49 -0800 (PST)
    David Rientjes <rientjes@google.com> wrote:

    > On Mon, 7 Mar 2011, Andrew Vagin wrote:
    >
    > > > Andrey is patching the case where an eligible TIF_MEMDIE process is found
    > > > but it has already detached its ->mm. __In combination with the patch
    > > > posted to linux-mm, oom: prevent unnecessary oom kills or kernel panics,
    > > > which makes select_bad_process() iterate over all threads, it is an
    > > > effective solution.
    > >
    > > Probably you said about the first version of my patch.
    > > This version is incorrect because of
    > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=dd8e8f405ca386c7ce7cbb996ccd985d283b0e03
    > >
    > > but my first patch is correct and it has a simple reproducer(I
    > > attached it). You can execute it and your kernel hangs up, because the
    > > parent doesn't wait children, but the one child (zombie) will have
    > > flag TIF_MEMDIE, oom_killer will kill nobody
    > >
    >
    > The second version of your patch works fine in combination with the
    > pending "oom: prevent unnecessary oom kills or kernel panics" patch from
    > linux-mm (included below).

    Andrew's v2 doesn't apply on top of
    oom-prevent-unnecessary-oom-kills-or-kernel-panics.patch and I'm
    disinclined to fix that up and merge some untested patch combination.



    \
     
     \ /
      Last update: 2011-03-07 22:55    [W:4.125 / U:0.492 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site