lkml.org 
[lkml]   [2011]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 11/21] staging: ft1000: Fix coding style in ft1000_usb_transmit_complete function.
    On Mon, Mar 07, 2011 at 09:21:16AM +0100, Marek Belisko wrote:
    > - if (urb->status)
    > - printk("%s: TX status %d\n", ft1000dev->net->name, urb->status);
    > + if (urb->status)
    > + DEBUG("%s: TX status %d\n", ft1000dev->net->name, urb->status);
    >

    Why did you change the printk() to a DEBUG()? That's a behavior change,
    and it should have been mentioned in the commit message.

    regards,
    dan carpenter

    > - netif_wake_queue(ft1000dev->net);
    > + netif_wake_queue(ft1000dev->net);
    >
    > //DEBUG("Return from ft1000_usb_transmit_complete\n");
    > }



    \
     
     \ /
      Last update: 2011-03-07 17:11    [W:0.020 / U:0.280 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site