lkml.org 
[lkml]   [2011]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [alsa-devel] [Device-drivers-devel] [PATCH] Add driver for Analog Devices ADAU1701 SigmaDSP
    On Sun, Mar 06, 2011 at 09:44:49PM -0500, Mike Frysinger wrote:
    > On Sun, Mar 6, 2011 at 20:11, <cliff.cai@analog.com> wrote:

    > > +static u32 adau1701_read_register(struct snd_soc_codec *codec,
    > > + ?? ?? ?? u16 reg_address, u8 length)
    > > +{

    > this func has "u32" for ret, and you return the raw register value
    > below. but here you try returning -EIO. shouldnt it be "int" so the
    > caller can check for "< 0" ?

    This is the interface we have, unfortuantely. It's not ideal but it'd
    be a complete pain to change it and the actual benefit in production is
    questionable given our lack of options for dealing with them in typical
    systems beyond moaning in logs.

    > > +struct snd_soc_dai_driver adau1701_dai = {
    > > + ?? ?? ?? .name = "ADAU1701",

    > i think the standard is to use all lower case

    Typically, yes.

    > > +MODULE_DESCRIPTION("ASoC ADAU1701 SigmaDSP driver");
    > > +MODULE_AUTHOR("Cliff Cai");
    > > +MODULE_LICENSE("GPL");

    > MODULE_ALIAS() ?

    That's not needed for I2C devices, it's handled by MODULE_DEVICE_TABLE()
    for I2C.


    \
     
     \ /
      Last update: 2011-03-07 12:47    [W:0.021 / U:31.516 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site