lkml.org 
[lkml]   [2011]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv2 12/24] sys_swapon: use a single error label
On Sat,  5 Mar 2011 13:42:13 -0300
Cesar Eduardo Barros <cesarb@cesarb.net> wrote:

> sys_swapon currently has two error labels, bad_swap and bad_swap_2.
> bad_swap does the same as bad_swap_2 plus destroy_swap_extents() and
> swap_cgroup_swapoff(); both are noops in the places where bad_swap_2 is
> jumped to. With a single extra test for inode (matching the one in the
> S_ISREG case below), all the error paths in the function can go to
> bad_swap.
>
> Signed-off-by: Cesar Eduardo Barros <cesarb@cesarb.net>
> Tested-by: Eric B Munson <emunson@mgebm.net>
> Acked-by: Eric B Munson <emunson@mgebm.net>


Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>



\
 
 \ /
  Last update: 2011-03-07 11:01    [W:0.129 / U:0.640 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site