[lkml]   [2011]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCHv2 11/24] sys_swapon: do only cleanup in the cleanup blocks
On Sat,  5 Mar 2011 13:42:12 -0300
Cesar Eduardo Barros <> wrote:

> The only way error is 0 in the cleanup blocks is when the function is
> returning successfully. In this case, the cleanup blocks were setting
> S_SWAPFILE in the S_ISREG case. But this is not a cleanup.
> Move the setting of S_SWAPFILE to just before the "goto out;" to make
> this more clear. At this point, we do not need to test for inode because
> it will never be NULL.
> Signed-off-by: Cesar Eduardo Barros <>
> Tested-by: Eric B Munson <>
> Acked-by: Eric B Munson <>

Reviewed-by: KAMEZAWA Hiroyuki <>

 \ /
  Last update: 2011-03-07 10:57    [W:0.159 / U:1.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site