| Date | Mon, 7 Mar 2011 18:48:29 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | Re: [PATCHv2 11/24] sys_swapon: do only cleanup in the cleanup blocks |
| |
On Sat, 5 Mar 2011 13:42:12 -0300 Cesar Eduardo Barros <cesarb@cesarb.net> wrote:
> The only way error is 0 in the cleanup blocks is when the function is > returning successfully. In this case, the cleanup blocks were setting > S_SWAPFILE in the S_ISREG case. But this is not a cleanup. > > Move the setting of S_SWAPFILE to just before the "goto out;" to make > this more clear. At this point, we do not need to test for inode because > it will never be NULL. > > Signed-off-by: Cesar Eduardo Barros <cesarb@cesarb.net> > Tested-by: Eric B Munson <emunson@mgebm.net> > Acked-by: Eric B Munson <emunson@mgebm.net>
Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
|