Messages in this thread | | | Date | Sun, 06 Mar 2011 14:32:43 +0200 | From | Avi Kivity <> | Subject | Re: [PATCH 10/10] KVM: cleanup memslot_id function |
| |
On 03/04/2011 01:02 PM, Xiao Guangrong wrote: > We can get memslot id from memslot->id directly > > > @@ -388,6 +387,12 @@ int kvm_gfn_to_hva_cache_init(struct kvm *kvm, struct gfn_to_hva_cache *ghc, > int kvm_clear_guest_page(struct kvm *kvm, gfn_t gfn, int offset, int len); > int kvm_clear_guest(struct kvm *kvm, gpa_t gpa, unsigned long len); > struct kvm_memory_slot *gfn_to_memslot(struct kvm *kvm, gfn_t gfn); > + > +static inline int memslot_id(struct kvm *kvm, gfn_t gfn) > +{ > + return gfn_to_memslot(kvm, gfn)->id; > +} > + > int kvm_is_visible_gfn(struct kvm *kvm, gfn_t gfn); > unsigned long kvm_host_page_size(struct kvm *kvm, gfn_t gfn); > void mark_page_dirty(struct kvm *kvm, gfn_t gfn);
Please put the function near the other inlines.
-- error compiling committee.c: too many arguments to function
| |