Messages in this thread | | | From | Oliver Neukum <> | Subject | Re: [PATCH] [media] dib0700: get rid of on-stack dma buffers | Date | Sun, 6 Mar 2011 13:06:09 +0100 |
| |
Am Sonntag, 6. März 2011, 12:16:52 schrieb Florian Mickler: > This should fix warnings seen by some: > WARNING: at lib/dma-debug.c:866 check_for_stack > > Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=15977. > Reported-by: Zdenek Kabelac <zdenek.kabelac@gmail.com> > Signed-off-by: Florian Mickler <florian@mickler.org> > CC: Mauro Carvalho Chehab <mchehab@infradead.org> > CC: linux-media@vger.kernel.org > CC: linux-kernel@vger.kernel.org > CC: Greg Kroah-Hartman <greg@kroah.com> > CC: Rafael J. Wysocki <rjw@sisk.pl> > CC: Maciej Rutecki <maciej.rutecki@gmail.com> > --- > > Please take a look at it, as I do not do that much kernel hacking > and don't wanna brake anybodys computer... :) > > From my point of view this should _not_ go to stable even though it would > be applicable. But if someone feels strongly about that and can > take responsibility for that change...
The patch looks good and is needed in stable. It could be improved by using a buffer allocated once in the places you hold a mutex anyway.
Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |