lkml.org 
[lkml]   [2011]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] mm: remove inline from scan_swap_map
    Date
    scan_swap_map is a large function (224 lines), with several loops and a
    complex control flow involving several gotos.

    Given all that, it is a bit silly that is is marked as inline. The
    compiler agrees with me: on a x86-64 compile, it did not inline the
    function.

    Remove the "inline" and let the compiler decide instead.

    Signed-off-by: Cesar Eduardo Barros <cesarb@cesarb.net>
    ---
    mm/swapfile.c | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/mm/swapfile.c b/mm/swapfile.c
    index 0341c57..8ed42e7 100644
    --- a/mm/swapfile.c
    +++ b/mm/swapfile.c
    @@ -212,8 +212,8 @@ static int wait_for_discard(void *word)
    #define SWAPFILE_CLUSTER 256
    #define LATENCY_LIMIT 256

    -static inline unsigned long scan_swap_map(struct swap_info_struct *si,
    - unsigned char usage)
    +static unsigned long scan_swap_map(struct swap_info_struct *si,
    + unsigned char usage)
    {
    unsigned long offset;
    unsigned long scan_base;
    --
    1.7.4


    \
     
     \ /
      Last update: 2011-03-06 12:29    [W:0.032 / U:62.204 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site