lkml.org 
[lkml]   [2011]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCHv2 02/24] sys_swapon: remove changelog from function comment
    On Sat, 5 Mar 2011, Cesar Eduardo Barros wrote:

    > Changelogs belong in the git history instead of in the source code.
    >
    > Also, "The swapon system call" is redundant with
    > "SYSCALL_DEFINE2(swapon, ...)".
    >
    > Signed-off-by: Cesar Eduardo Barros <cesarb@cesarb.net>
    > Tested-by: Eric B Munson <emunson@mgebm.net>
    > Acked-by: Eric B Munson <emunson@mgebm.net>
    > ---
    > mm/swapfile.c | 5 -----
    > 1 files changed, 0 insertions(+), 5 deletions(-)
    >
    > diff --git a/mm/swapfile.c b/mm/swapfile.c
    > index 3fe8913..75ee39c 100644
    > --- a/mm/swapfile.c
    > +++ b/mm/swapfile.c
    > @@ -1844,11 +1844,6 @@ static int __init max_swapfiles_check(void)
    > late_initcall(max_swapfiles_check);
    > #endif
    >
    > -/*
    > - * Written 01/25/92 by Simmule Turner, heavily changed by Linus.
    > - *
    > - * The swapon system call
    > - */

    Second line in the comment can hardly be called "changelog".

    Removing the comment won't break anything, so

    Reviewed-by: Jesper Juhl <jj@chaosbits.net>

    --
    Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
    Plain text mails only, please.
    Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html



    \
     
     \ /
      Last update: 2011-03-06 12:19    [W:0.022 / U:120.684 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site