lkml.org 
[lkml]   [2011]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv2 08/24] sys_swapon: move setting of error nearer use
On Sat, 5 Mar 2011, Cesar Eduardo Barros wrote:

> Move the setting of the error variable nearer the goto in a few places.
>
> Avoids calling PTR_ERR() if not IS_ERR() in two places, and makes the
> error condition more explicit in two other places.
>
> Signed-off-by: Cesar Eduardo Barros <cesarb@cesarb.net>
> Tested-by: Eric B Munson <emunson@mgebm.net>
> Acked-by: Eric B Munson <emunson@mgebm.net>

Looks good to me.

Reviewed-by: Jesper Juhl <jj@chaosbits.net>

--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Plain text mails only, please.
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html



\
 
 \ /
  Last update: 2011-03-06 12:31    [from the cache]
©2003-2011 Jasper Spaans