lkml.org 
[lkml]   [2011]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 09/27] nfs: writeback pages wait queue
From
Date
On Fri, 2011-03-04 at 10:10 +0100, Peter Zijlstra wrote:
> On Fri, 2011-03-04 at 10:01 +0800, Wu Fengguang wrote:
> > clear_bdi_congested(bdi, BLK_RW_SYNC);
> > /*
> > * On the following wake_up(), nfs_wait_congested()
> > * will see the cleared bit and quit.
> > */
> > smp_mb__after_clear_bit();
> > }
> > if (waitqueue_active(&wqh[BLK_RW_SYNC]))
> > wake_up(&wqh[BLK_RW_SYNC]);
>
> If I tell you that: try_to_wake_up() implies an smp_wmb(), do you then
> still need this?

Also, there is no matching rmb,mb in nfs_wait_congested().. barrier
always come in pairs.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-03-06 12:29    [from the cache]
©2003-2011 Jasper Spaans