lkml.org 
[lkml]   [2011]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] tcp: ioctl type SIOCOUTQNSD returns amount of data not sent
    Am 04.03.2011 12:49, schrieb Alan Cox:
    > ...
    >>> Signed-off-by: Mario Schuknecht <m.schuknecht@dresearch.de>
    >>> ---
    >>> include/asm-generic/ioctls.h | 1 +
    >>> include/linux/sockios.h | 1 +
    >>> net/ipv4/tcp.c | 9 +++++++++
    >>> 3 files changed, 11 insertions(+), 0 deletions(-)
    >>>
    >>> diff --git a/include/asm-generic/ioctls.h b/include/asm-generic/ioctls.h
    >>> index a321665..b87115b 100644
    >>> --- a/include/asm-generic/ioctls.h
    >>> +++ b/include/asm-generic/ioctls.h
    >>> @@ -72,6 +72,7 @@
    >>> #define TCSETXF 0x5434
    >>> #define TCSETXW 0x5435
    >>> #define TIOCSIG _IOW('T', 0x36, int) /* pty: generate signal */
    >>> +#define TIOCOUTQNSD 0x5437
    >
    > These are tty not socket ioctl codes. For various historical reasons some
    > of them got sort of emulated by the socket layer in Unix and thus in
    > Linux.
    >
    > If you plan to add one to Linux then please post the accompanying *tty
    > layer* patches and reasoning, otherwise if it is socket only please stick
    > to the socket ioctl.

    So we should define the new SIOCOUTQNSD in sockios.h only and not similiar to SIOCOUTQ using TIOCOUTQ. Right?

    Steffen

    --
    DResearch Fahrzeugelektronik GmbH
    Otto-Schmirgal-Str. 3, 10319 Berlin, Germany
    Tel: +49 30 515932-237 mailto:sledz@DResearch.de
    Fax: +49 30 515932-299
    Geschäftsführer: Dr. Michael Weber, Werner Mögle;
    Amtsgericht Berlin Charlottenburg; HRB 130120 B;
    Ust.-IDNr. DE273952058

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-03-06 12:29    [W:4.028 / U:11.744 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site