lkml.org 
[lkml]   [2011]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH rh6] mm: skip zombie in OOM-killer
    On 03/05/2011 02:41 AM, David Rientjes wrote:
    > On Sat, 5 Mar 2011, Andrey Vagin wrote:
    >
    >> diff --git a/mm/oom_kill.c b/mm/oom_kill.c
    >> index 7dcca55..2fc554e 100644
    >> --- a/mm/oom_kill.c
    >> +++ b/mm/oom_kill.c
    >> @@ -311,7 +311,7 @@ static struct task_struct *select_bad_process(unsigned int *ppoints,
    >> * blocked waiting for another task which itself is waiting
    >> * for memory. Is there a better alternative?
    >> */
    >> - if (test_tsk_thread_flag(p, TIF_MEMDIE))
    >> + if (test_tsk_thread_flag(p, TIF_MEMDIE)&& p->mm)
    >> return ERR_PTR(-1UL);
    >>
    >> /*
    >
    > I think it would be better to just do
    >
    > if (!p->mm)
    > continue;
    >
    > after the check for oom_unkillable_task() because everything that follows
    > this really depends on p->mm being non-NULL to actually do anything
    > useful.
    Yes. You are right. Thank you.


    \
     
     \ /
      Last update: 2011-03-06 12:27    [W:4.034 / U:15.620 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site