Messages in this thread | | | From | Andrew Lutomirski <> | Date | Fri, 4 Mar 2011 13:53:41 -0500 | Subject | Re: [PATCH v5 00/11] hwmon: (w83627ehf) Add support for NCT6775F and NCT6776F |
| |
On Fri, Mar 4, 2011 at 1:50 PM, Andrew Lutomirski <luto@mit.edu> wrote: > On Fri, Mar 4, 2011 at 12:57 PM, Guenter Roeck > <guenter.roeck@ericsson.com> wrote: >> The following patch series adds support for NCT6775F and NCT6776F to the >> w83627ehf driver. It also includes some cleanup and adds support for >> the fourth temperature sensor on W83677HG-B. >> >> No code changes since v4. Resubmitting and widening audience in the hope that >> someone may find the time to review the changes prior to the next commit window. > > I'm not sure my review is worth much, but the driver seems to work. I've tested > fan speed measurement, changing pwm2_enable to 1, changing the fan speed, > and changing back to 5. Everything looks good. > > The only weird thing I noticed is that, the first time I ran sensors, I got: > fan2: 0 RPM (min = 0 RPM, div = 64) > and thereafter I get > fan2: 136 RPM (min = 0 RPM, div = 64) ALARM > > I suspect (although I haven't checked) that sensors is just reading > div after it's already changed to 64.
I'll add one more weird thing on my NCT6775F.
[root@midnight w83627ehf.656]# echo 3200 >fan2_min [root@midnight w83627ehf.656]# cat fan2_div 8 [root@midnight w83627ehf.656]# cat fan2_input 133 [root@midnight w83627ehf.656]# cat fan2_div 16 [root@midnight w83627ehf.656]# cat fan2_input 133 [root@midnight w83627ehf.656]# cat fan2_div 32 [root@midnight w83627ehf.656]# cat fan2_input 133 [root@midnight w83627ehf.656]# cat fan2_div 64 [root@midnight w83627ehf.656]# cat fan2_input 132 [root@midnight w83627ehf.656]# cat fan2_div 64
I waited a second or two between commands.
Does this mean that 16-bit mode works but the driver doesn't realize it works?
--Andy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |