lkml.org 
[lkml]   [2011]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: [PATCH 0/2] Re: 2.6.38 regression caused by commit 415e12b
Date
On Friday, March 04, 2011, Sarah Sharp wrote:
> On Wed, Mar 02, 2011 at 11:30:49PM +0100, Rafael J. Wysocki wrote:
> > On Wednesday, March 02, 2011, Rafael J. Wysocki wrote:
> > > There are two problems. First, your BIOS says that ASPM is not supported
> > > by it, so we don't call _OSC, which should be fixed by the previous patch.
> > > Second, pci_msi_enabled() returns 0 on your system, which is kind of strange,
> > > because it evidently uses MSIs (as visible in the dmesg).
> > >
> > > While I think we can safely request _OSC control even if ASPM is not supported
> > > by the hardware (according to the BIOS), which is done after the first patch,
> > > we need to figure out why 0 is returned by pci_msi_enabled() on your system
> > > and try to work around that.
> >
> > Regardless, I think we should report MSI and ASPM support to the BIOS unless
> > directly disabled via the kernel command line or .config.
> >
> > I'm going to send two patches in replies to this message. Please apply them
> > both on top of 2.6.38-rc7 and report back.
>
> I applied your patches on top of 2.6.38-rc6 again and tested them.
> dmesg is attached. Let me know if you need me to test Linus' latest
> instead.

-rc6 should be fine.

I don't understand why pci_no_msi_support() is called on your system even
though pci=nomsi is not in the kernel command line.

Please apply this patch on top of the previous two and send me dmesg.

---
drivers/pci/msi.c | 2 ++
1 file changed, 2 insertions(+)
Index: linux-2.6/drivers/pci/msi.c
===================================================================
--- linux-2.6.orig/drivers/pci/msi.c
+++ linux-2.6/drivers/pci/msi.c
@@ -858,6 +858,8 @@ void pci_no_msi(void)

void pci_no_msi_support(void)
{
+ dump_stack();
+
msi_support_enabled = false;
pci_no_msi();
}

\
 
 \ /
  Last update: 2011-03-06 12:19    [from the cache]
©2003-2011 Jasper Spaans