lkml.org 
[lkml]   [2011]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:perf/core] perf cgroup: Clean up perf_cgroup_create()
    Commit-ID:  1b15d0558e82df9b3659804ceb44187b98eda354
    Gitweb: http://git.kernel.org/tip/1b15d0558e82df9b3659804ceb44187b98eda354
    Author: Li Zefan <lizf@cn.fujitsu.com>
    AuthorDate: Thu, 3 Mar 2011 14:26:06 +0800
    Committer: Ingo Molnar <mingo@elte.hu>
    CommitDate: Fri, 4 Mar 2011 11:32:51 +0100

    perf cgroup: Clean up perf_cgroup_create()

    - Use kzalloc() to replace kmalloc() + memset().

    - Remove redundant initialization, since alloc_percpu() returns
    zero-filled percpu memory.

    Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
    Acked-by: Stephane Eranian <eranian@google.com>
    Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
    LKML-Reference: <4D6F347E.2010806@cn.fujitsu.com>
    Signed-off-by: Ingo Molnar <mingo@elte.hu>
    ---
    kernel/perf_event.c | 11 +----------
    1 files changed, 1 insertions(+), 10 deletions(-)

    diff --git a/kernel/perf_event.c b/kernel/perf_event.c
    index b002095..193b190 100644
    --- a/kernel/perf_event.c
    +++ b/kernel/perf_event.c
    @@ -7346,26 +7346,17 @@ static struct cgroup_subsys_state *perf_cgroup_create(
    struct cgroup_subsys *ss, struct cgroup *cont)
    {
    struct perf_cgroup *jc;
    - struct perf_cgroup_info *t;
    - int c;

    - jc = kmalloc(sizeof(*jc), GFP_KERNEL);
    + jc = kzalloc(sizeof(*jc), GFP_KERNEL);
    if (!jc)
    return ERR_PTR(-ENOMEM);

    - memset(jc, 0, sizeof(*jc));
    -
    jc->info = alloc_percpu(struct perf_cgroup_info);
    if (!jc->info) {
    kfree(jc);
    return ERR_PTR(-ENOMEM);
    }

    - for_each_possible_cpu(c) {
    - t = per_cpu_ptr(jc->info, c);
    - t->time = 0;
    - t->timestamp = 0;
    - }
    return &jc->css;
    }


    \
     
     \ /
      Last update: 2011-03-06 11:41    [W:0.025 / U:5.448 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site