lkml.org 
[lkml]   [2011]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] ptp: add a software clock based on clock_monotonic_raw
On Thu, Mar 03, 2011 at 06:26:13PM +0100, Torben Hohn wrote:
> +config PTP_1588_CLOCK_SOFTWARE
> + tristate "software PTP clock"
> + depends on PTP_1588_CLOCK
> + help
> + This driver adds a software PTP clock.

As John said, this needs a longer description. You can look back at
my V6 as an example.

https://lkml.org/lkml/2010/9/23/220

> +static int ptp_ixp_adjfreq(struct ptp_clock_info *ptp, s32 ppb)

Once again, please rename.

Better yet, why not just use the V6 example instead? If we are going
to have a testing driver, then I would want the simulated ancillary
code as well.

> +
> +static struct ptp_clock_info ptp_ixp_caps = {
> + .owner = THIS_MODULE,
> + .name = "software timer",
> + .max_adj = 66666655,

You should calculate the actual limit of adjustment and use it here.

Thanks,

Richard





\
 
 \ /
  Last update: 2011-03-04 07:49    [W:0.126 / U:2.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site