lkml.org 
[lkml]   [2011]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: regression - 2.6.36 -> 2.6.37 - kvm - 32bit SMP guests don't boot
    On 03/04/2011 05:36 PM, Nikola Ciprich wrote:
    >> I think although the long term plan is to just do this update once in
    >> your case (stable tsc), this update is needed.
    >>
    >> Why don't you send a patch to re-include it ?
    >>
    >>
    > Yes, I'll gladly submit patch, one question, is this OK
    > to just add calling kvm_make_request(KVM_REQ_CLOCK_UPDATE, vcpu) before
    > the conditional (as I did in my test), or should it go somewhere to else {..}
    > section? it's called inside the conditional again, which will cause it
    > to be called twice in some cases, is it OK?
    > n.
    >
    >

    Can you try this patch to see if it fixes the problem?

    Thanks,

    Zach
    diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
    index 468fafa..ba05303 100644
    --- a/arch/x86/kvm/x86.c
    +++ b/arch/x86/kvm/x86.c
    @@ -1866,6 +1866,7 @@ void kvm_arch_vcpu_load(struct kvm_vcpu *vcpu, int cpu)
    }

    kvm_x86_ops->vcpu_load(vcpu, cpu);
    + kvm_request_guest_time_update(vcpu);
    if (unlikely(vcpu->cpu != cpu)) {
    /* Make sure TSC doesn't go backwards */
    s64 tsc_delta = !vcpu->arch.last_host_tsc ? 0 :
    \
     
     \ /
      Last update: 2011-03-06 11:19    [W:4.014 / U:44.268 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site