lkml.org 
[lkml]   [2011]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch] x86, mm: Clean up initmem_init
    Hello,

    On Thu, Mar 03, 2011 at 01:15:04PM -0800, David Rientjes wrote:
    > This patch cleans initmem_init() so that it is more readable and doesn't
    > use an unnecessary array of function pointers to convolute the flow of
    > the code. It also makes it obvious that dummy_numa_init() will always
    > succeed (and documents that requirement) so that the existing BUG() is
    > never actually reached.
    >
    > No functional change.
    >
    > Signed-off-by: David Rientjes <rientjes@google.com>

    Just a nitpick.

    > +/*
    > + * Used if there's no underlying NUMA architecture, NUMA initialization fails,
    > + * or NUMA is disabled on the command line.
    > + *
    > + * Must online at least one node and add memory blocks that cover all allowed
    > + * memory.
    > + */

    Can you please reformat to docbook style?

    Thanks.

    --
    tejun


    \
     
     \ /
      Last update: 2011-03-06 11:19    [W:0.020 / U:0.920 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site