lkml.org 
[lkml]   [2011]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] gpio: pch_gpio: Fix output value of pch_gpio_direction_output()
On Fri, Mar 25, 2011 at 10:04:00AM -0500, Peter Tyser wrote:
> The pch_gpio_direction_output() function was missing a write to set the
> desired output value. The function would properly set the GPIO
> direction, but not the output value. The value would have to manually
> be set with a follow up call to pch_gpio_set().
>
> Add the missing write so that pch_gpio_direction_output() sets both the
> GPIO direction and value.
>
> Signed-off-by: Peter Tyser <ptyser@xes-inc.com>
> Cc: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>
> Cc: Toshiharu Okada <toshiharu-linux@dsn.okisemi.com>
> Cc: Grant Likely <grant.likely@secretlab.ca>

Applied, thanks.

g.
> ---
> Just noticed this driver has the same bug. This file looks nearly identical
> to ml_ioh_gpio.c. They could likely be combined with minimal effort.
>
> drivers/gpio/pch_gpio.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/gpio/pch_gpio.c b/drivers/gpio/pch_gpio.c
> index c59d953..fa52862 100644
> --- a/drivers/gpio/pch_gpio.c
> +++ b/drivers/gpio/pch_gpio.c
> @@ -105,6 +105,7 @@ static int pch_gpio_direction_output(struct gpio_chip *gpio, unsigned nr,
> reg_val |= (1 << nr);
> else
> reg_val &= ~(1 << nr);
> + iowrite32(reg_val, &chip->reg->po);
>
> mutex_unlock(&chip->lock);
>
> --
> 1.7.0.4
>


\
 
 \ /
  Last update: 2011-03-31 23:21    [W:0.074 / U:0.560 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site