lkml.org 
[lkml]   [2011]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/9] x86 idle: remove NOP cpuinfo_x86.hlt_works_ok flag

* Len Brown <lenb@kernel.org> wrote:

> From: Len Brown <len.brown@intel.com>
>
> hlt_works_ok was X86_32 only, initialized to 1, and never cleared.
>
> On 32-bit kernels, this deletes a line from /proc/cpuinfo: "hlt_bug : no"

I think you missed the valid usecase where an old CPU with broken halt is
booted with the no-hlt boot parameter and does not want to crash in the HLT
instruction.

That "no-hlt" boot parameter does:

arch/x86/kernel/cpu/bugs.c: boot_cpu_data.hlt_works_ok = 0;

We can restrict compatibility, but *please* lets do it *explicitly*, not under
some 'remove unused code' pretense ...

Could you please list all CPU models that are affected?

Thanks,

Ingo


\
 
 \ /
  Last update: 2011-03-31 08:15    [W:0.127 / U:0.452 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site