lkml.org 
[lkml]   [2011]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [GIT PULL] Fix common misspellings
Hi Ingo,

On Thu, Mar 31, 2011 at 3:29 AM, Ingo Molnar <mingo@elte.hu> wrote:
> I've gone over your changes and noticed one very small thing, you've changed
> copyright strings as well:
>
> - * Copyright (C) 2007 Marvell Internation Ltd.
> + * Copyright (C) 2007 Marvell International Ltd.
> - * Copyright (C) 2007 Marvell Internation Ltd.
> + * Copyright (C) 2007 Marvell International Ltd.
> - * Copyright (C) 2007 Marvell Internation Ltd.
> + * Copyright (C) 2007 Marvell International Ltd.
> - * Copyright (C) 2007-2008 Marvell Internation Ltd.
> + * Copyright (C) 2007-2008 Marvell International Ltd.
> - * Copyright (C) 2007 Marvell Internation Ltd.
> + * Copyright (C) 2007 Marvell International Ltd.
> - * Copyright (C) 2007 Marvell Internation Ltd.
> + * Copyright (C) 2007 Marvell International Ltd.
> - * Copyright (C) 2007 Marvell Internation Ltd.
> + * Copyright (C) 2007 Marvell International Ltd.
> - * Copyright (c) 2002 The Regents of the Unviersity of Michigan
> + * Copyright (c) 2002 The Regents of the University of Michigan
>
> While all the fixes are correct, i'd advise against changing copyright notices
> without the SOB of the authors. The s/Unviersity/University fix would be ok i
> guess because it's a very clear typo, but the Marvell one is borderline (while
> it too is probably a typo) i think it needs a signoff from those who put the
> copyright notices there in that form.
>
> You could leave out those bits from the patch as well.

Ok. I saw these when manually reviewing and a 'git grep "Marvell
International Ltd"' revealed a lot of places using "the right form",
so I assumed they were in fact typos.

I'll remove them for now, and send a separate patch later asking for
the required s-o-b.


thanks
Lucas De Marchi


\
 
 \ /
  Last update: 2011-03-31 15:55    [W:0.166 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site