lkml.org 
[lkml]   [2011]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/1] drivers: brcmaxi: provide amba axi functionality in separate module
    On 03/30/2011 02:53 PM, Arnd Bergmann wrote:
    > On Tuesday 29 March 2011, Jiri Slaby wrote:
    >> On 03/29/2011 11:40 AM, Arend van Spriel wrote:
    >>> --- /dev/null
    >>> +++ b/drivers/brcmaxi/axi.c
    >>> @@ -0,0 +1,786 @@
    >> ...
    >>> +/* resetctrl */
    >>> +#define AIRC_RESET 1
    >>> +
    >>> +/* definition for specifying padding fields */
    >>> +#define _PADLINE(line) pad ## line
    >>> +#define _XSTR(line) _PADLINE(line)
    >>> +#define PAD _XSTR(__LINE__)
    >>> +
    >>> +/*
    >>> + * struct aidmp - device management plugin "wrapper" registers.
    >>> + */
    >>> +struct aidmp {
    >>
    >> This looks like it should be __packed__.
    >
    > Why that? Adding the packed attribute would enforce byte access but
    > not change the layout of the structure, so I think that would make
    > it worse not better.

    How it can? Packed only tells the compiler to have one byte alignment
    steps. And it should not matter here as all the members are 32-bit long.

    The structure seems to be something which maps to device registers. So
    for documentation purposes it should be packed. And to avoid later
    mistakes when the u32 are broken down to u8s and u16s.

    regards,
    --
    js
    suse labs


    \
     
     \ /
      Last update: 2011-03-31 15:51    [W:0.024 / U:61.912 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site