lkml.org 
[lkml]   [2011]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH]arch:x86:kvm:i8254.h Fix typo in kvm_pit
On Wed, 30 Mar 2011, Avi Kivity wrote:

> > > > The below patch changes base_addresss to base_address.
> > > > Note: I have grepped for base_addresss and nothing shows up,
> > > > grepping for base_address gets me lots of output, telling me that
> > > > this is a typo, but could be wrong.
> > > >
> > > > Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
> > > >
> > > > ---
> > > > arch/x86/kvm/i8254.h | 2 +-
> > > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > > >
> > > > diff --git a/arch/x86/kvm/i8254.h b/arch/x86/kvm/i8254.h
> > > > index 46d08ca..c2fa48b 100644
> > > > --- a/arch/x86/kvm/i8254.h
> > > > +++ b/arch/x86/kvm/i8254.h
> > > > @@ -33,7 +33,7 @@ struct kvm_kpit_state {
> > > > };
> > > >
> > > > struct kvm_pit {
> > > > - unsigned long base_addresss;
> > > > + unsigned long base_address;
> > > > struct kvm_io_device dev;
> > > > struct kvm_io_device speaker_dev;
> > > > struct kvm *kvm;
> > >
> > > Why not remove the variable completely?
> > >
> >
> > didnt even think to completely remove the variable(figured it was used
> > somewhere).I will look at that and resend with removal of the variable for
> > you..
>
> Well if it was used, you ought to have changed all of the users, no?

I am afraid Justin is not trying to compile-test his patches (I got this
suspicion after last patchset trying to remove all the includes of
version.h).

--
Jiri Kosina
SUSE Labs, Novell Inc.


\
 
 \ /
  Last update: 2011-03-31 00:23    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean