| From | Andi Kleen <> | Subject | [PATCH] [270/275] KVM: i8259: initialize isr_ack | Date | Wed, 30 Mar 2011 14:08:37 -0700 (PDT) |
| |
2.6.35-longterm review patch. If anyone has any objections, please let me know.
------------------ From: Avi Kivity <avi@redhat.com>
commit a0272630bb594b4eac03a79e77957df7dad8eade upstream.
isr_ack is never initialized. So, until the first PIC reset, interrupts may fail to be injected. This can cause Windows XP to fail to boot, as reported in the fallout from the fix to https://bugzilla.kernel.org/show_bug.cgi?id=21962.
Reported-and-tested-by: Nicolas Prochazka <prochazka.nicolas@gmail.com> Signed-off-by: Avi Kivity <avi@redhat.com> Signed-off-by: Andi Kleen <ak@linux.intel.com>
--- arch/x86/kvm/i8259.c | 2 ++ 1 file changed, 2 insertions(+)
Index: linux-2.6.35.y/arch/x86/kvm/i8259.c =================================================================== --- linux-2.6.35.y.orig/arch/x86/kvm/i8259.c 2011-01-13 09:47:51.000000000 -0800 +++ linux-2.6.35.y/arch/x86/kvm/i8259.c 2011-03-29 23:47:12.738423232 -0700 @@ -553,6 +553,8 @@ s->irq_request_opaque = kvm; s->pics[0].pics_state = s; s->pics[1].pics_state = s; + s->pics[0].isr_ack = 0xff; + s->pics[1].isr_ack = 0xff; /* * Initialize PIO device
|