lkml.org 
[lkml]   [2011]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] input/touchscreen: Synaptics RMI4 Touchscreen Driver
Hi,

> + retval = rmi_register_sensor(&instancedata->rmiphysdrvr, platformdata->perfunctiondata);
> + if (retval) {
> + dev_err(&client->dev, "%s: Failed to Register %s sensor drivers\n",
> + __func__, instancedata->rmiphysdrvr.name);
> + i2c_set_clientdata(client, NULL);

I originally just wanted to say that this line can be removed. Then I
remembered that I already sent a patch for a similar driver in staging
(dc7b202a4ee6cb686e2bbef80c84443f43ec91bd). The staging driver looks in
a better shape to me. Do you know about it?

Regards,

Wolfram

--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2011-03-30 10:05    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site