lkml.org 
[lkml]   [2011]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] [137/275] platform: x86: asus_acpi: world-writable procfs files
    Date
    2.6.35-longterm review patch.  If anyone has any objections, please let me know.

    ------------------
    From: Vasiliy Kulikov <segoon@openwall.com>

    commit 8040835760adf0ef66876c063d47f79f015fb55d upstream.

    Don't allow everybody to change ACPI settings. The comment says that it
    is done deliberatelly, however, the comment before disp_proc_write()
    says that at least one of these setting is experimental.

    Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
    Signed-off-by: Matthew Garrett <mjg@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Signed-off-by: Andi Kleen <ak@linux.intel.com>

    ---
    drivers/platform/x86/asus_acpi.c | 8 +-------
    1 file changed, 1 insertion(+), 7 deletions(-)

    Index: linux-2.6.35.y/drivers/platform/x86/asus_acpi.c
    ===================================================================
    --- linux-2.6.35.y.orig/drivers/platform/x86/asus_acpi.c 2011-03-29 22:51:12.619400270 -0700
    +++ linux-2.6.35.y/drivers/platform/x86/asus_acpi.c 2011-03-29 23:03:01.117271582 -0700
    @@ -1079,14 +1079,8 @@
    struct proc_dir_entry *proc;
    mode_t mode;

    - /*
    - * If parameter uid or gid is not changed, keep the default setting for
    - * our proc entries (-rw-rw-rw-) else, it means we care about security,
    - * and then set to -rw-rw----
    - */
    -
    if ((asus_uid == 0) && (asus_gid == 0)) {
    - mode = S_IFREG | S_IRUGO | S_IWUGO;
    + mode = S_IFREG | S_IRUGO | S_IWUSR | S_IWGRP;
    } else {
    mode = S_IFREG | S_IRUSR | S_IRGRP | S_IWUSR | S_IWGRP;
    printk(KERN_WARNING " asus_uid and asus_gid parameters are "

    \
     
     \ /
      Last update: 2011-03-30 23:13    [W:0.019 / U:0.764 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site