lkml.org 
[lkml]   [2011]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] pl25a1_support
    From
    From: Simon Wood <simon@mungewell.org>
    Date: Tue, 29 Mar 2011 21:44:27 -0600

    > @@ -89,13 +97,17 @@ static int pl_reset(struct usbnet *dev)
    > /* some units seem to need this reset, others reject it utterly.
    > * FIXME be more like "naplink" or windows drivers.
    > */
    > - (void) pl_set_QuickLink_features(dev,
    > + int status;
    > +
    > + status = pl_set_QuickLink_features(dev,
    > PL_S_EN|PL_RESET_OUT|PL_RESET_IN|PL_PEER_E);

    Poor indentation here in the status assignment, there should be
    only a single TAB character before "status =".

    Also, declare the local variable at the beginning of the function,
    before the function, not after it. And get rid of that tab between
    "int" and "status, like this:

    int status;

    /* some units seem to need this reset, others reject it utterly.
    * FIXME be more like "naplink" or windows drivers.
    */


    \
     
     \ /
      Last update: 2011-03-30 11:43    [W:0.019 / U:194.344 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site