lkml.org 
[lkml]   [2011]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH 07/10] fs: make generic file read/write functions plug
    On Sat, Jan 22, 2011 at 01:17:26AM +0000, Jens Axboe wrote:
    > Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
    > ---
    > mm/filemap.c | 7 +++++++
    > 1 files changed, 7 insertions(+), 0 deletions(-)
    >
    > diff --git a/mm/filemap.c b/mm/filemap.c
    > index 380776c..f9a29c8 100644
    > --- a/mm/filemap.c
    > +++ b/mm/filemap.c
    > @@ -1243,12 +1243,15 @@ generic_file_aio_read(struct kiocb *iocb, const struct iovec *iov,
    > unsigned long seg = 0;
    > size_t count;
    > loff_t *ppos = &iocb->ki_pos;
    > + struct blk_plug plug;
    >
    > count = 0;
    > retval = generic_segment_checks(iov, &nr_segs, &count, VERIFY_WRITE);
    > if (retval)
    > return retval;
    >
    > + blk_start_plug(&plug);
    > +

    Jens,

    IIUC, read requests will be considered SYNC and it looks like that
    __make_request() will dispatch all the SYNC requests immediately. If
    that's the case then for read path blk_plug mechanism is not required?

    Thanks
    Vivek


    \
     
     \ /
      Last update: 2011-03-04 05:11    [W:0.021 / U:63.472 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site