lkml.org 
[lkml]   [2011]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] x86, mm: Clean up initmem_init
On 03/04/2011 01:05 AM, David Rientjes wrote:
> On Thu, 3 Mar 2011, Yinghai Lu wrote:
>
>> he want
>>
>>> +#ifdef CONFIG_ACPI_NUMA
>>>>> + ret = numa_init(x86_acpi_numa_init);
>>>>> + if (!ret)
>>>>> + return;
>>>>> +#endif
>>>>> +#ifdef CONFIG_AMD_NUMA
>>>>> + ret = numa_init(amd_numa_init);
>>>>> + if (!ret)
>>>>> + return;
>>>>> +#endif
>>
>> to be replaced by:
>>
>>> +#ifdef CONFIG_ACPI_NUMA
>>>>> + if (!numa_init(x86_acpi_numa_init))
>>>>> + return;
>>>>> +#endif
>>>>> +#ifdef CONFIG_AMD_NUMA
>>>>> + if (!numa_init(amd_numa_init))
>>>>> + return;
>>>>> +#endif
>
> It's a matter of style and I think it's up to Ingo what he'd prefer to
> see.

i'm fine with either, just though it would shrink the code a bit (since there
is no need to track var witch i guess will be eliminated by gcc anyway).

nb: am i only the one who obtain bounce from shaohui.zheng@intel.com (so i'd to remove
him from cc'ing)?
--
Cyrill


\
 
 \ /
  Last update: 2011-03-03 23:13    [from the cache]
©2003-2011 Jasper Spaans