[lkml]   [2011]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v8 4/3] cgroups: use flex_array in attach_proc
On Wed, Feb 16, 2011 at 11:22 AM, Ben Blum <> wrote:
> Convert cgroup_attach_proc to use flex_array.
> From: Ben Blum <>
> The cgroup_attach_proc implementation requires a pre-allocated array to store
> task pointers to atomically move a thread-group, but asking for a monolithic
> array with kmalloc() may be unreliable for very large groups. Using flex_array
> provides the same functionality with less risk of failure.
> This is a post-patch for cgroup-procs-write.patch.
> Signed-off-by: Ben Blum <>

Reviewed-by: Paul Menage <>

Looks fine from a correctness point of view, but I'd be inclined to
reduce the verbosity - rather than

tsk = flex_array_get_ptr(group, i);
BUG_ON(tsk == NULL);
retval = ss->can_attach_task(cgrp, tsk);

I'd just have

retval = ss->can_attach_task(cgrp, flex_array_get_ptr(group, i));

I don't think you need to be so defensive about flex_array's behaviour.


 \ /
  Last update: 2011-03-03 18:51    [W:0.137 / U:16.964 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site