Messages in this thread | | | Date | Thu, 3 Mar 2011 07:30:07 +0100 | From | Tejun Heo <> | Subject | Re: [PATCH] x86, mm: clean up setup_node_bootmem |
| |
On Wed, Mar 02, 2011 at 05:19:29PM -0800, Yinghai Lu wrote: > only one user now, so change it to static
Can you please try to use proper sentences? ie.
There is only one user left now, so make it static.
> Also move validity checking into the fuction. > > Signed-off-by: Yinghai Lu <yinghai@kernel.org> ... > Index: linux-2.6/arch/x86/mm/numa_64.c > =================================================================== > --- linux-2.6.orig/arch/x86/mm/numa_64.c > +++ linux-2.6/arch/x86/mm/numa_64.c > @@ -237,21 +237,18 @@ int __init numa_add_memblk(int nid, u64 > } > > /* Initialize bootmem allocator for a node */ > -void __init > +static void __init > setup_node_bootmem(int nodeid, unsigned long start, unsigned long end) > { > unsigned long start_pfn, last_pfn, nodedata_phys; > const int pgdat_size = roundup(sizeof(pg_data_t), PAGE_SIZE); > int nid; > > - if (!end) > - return; > - > /* > * Don't confuse VM with a node that doesn't have the > * minimum amount of memory: > */ > - if (end && (end - start) < NODE_MIN_SIZE) > + if (end < (start + NODE_MIN_SIZE))
Please drop the parentheses.
Thanks.
-- tejun
| |