Messages in this thread | | | Date | Thu, 3 Mar 2011 09:59:08 -0500 | From | Don Zickus <> | Subject | Re: [PATCH 01/05] use proc_dointvec_minmax to check boundaries while needed |
| |
On Thu, Mar 03, 2011 at 09:58:20PM +0800, Dave Young wrote: > proc_dointvec doesn't check extra minmax params, use proc_dointvec_minmax > instead of proc_dointvec for cases need boundaries check.
Is this patch needed, if you are basically changing it again in patches 3 and 5?
Cheers, Don
> > Signed-off-by: Dave Young <hidave.darkstar@gmail.com> > --- > kernel/sysctl.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > --- linux-2.6.orig/kernel/sysctl.c 2011-03-03 10:44:53.000000000 +0800 > +++ linux-2.6/kernel/sysctl.c 2011-03-03 11:02:43.736663258 +0800 > @@ -374,7 +374,7 @@ static struct ctl_table kern_table[] = { > .data = &sysctl_sched_autogroup_enabled, > .maxlen = sizeof(unsigned int), > .mode = 0644, > - .proc_handler = proc_dointvec, > + .proc_handler = proc_dointvec_minmax, > .extra1 = &zero, > .extra2 = &one, > }, > @@ -1204,7 +1204,7 @@ static struct ctl_table vm_table[] = { > .data = &block_dump, > .maxlen = sizeof(block_dump), > .mode = 0644, > - .proc_handler = proc_dointvec, > + .proc_handler = proc_dointvec_minmax, > .extra1 = &zero, > }, > { > @@ -1212,7 +1212,7 @@ static struct ctl_table vm_table[] = { > .data = &sysctl_vfs_cache_pressure, > .maxlen = sizeof(sysctl_vfs_cache_pressure), > .mode = 0644, > - .proc_handler = proc_dointvec, > + .proc_handler = proc_dointvec_minmax, > .extra1 = &zero, > }, > #ifdef HAVE_ARCH_PICK_MMAP_LAYOUT > @@ -1221,7 +1221,7 @@ static struct ctl_table vm_table[] = { > .data = &sysctl_legacy_va_layout, > .maxlen = sizeof(sysctl_legacy_va_layout), > .mode = 0644, > - .proc_handler = proc_dointvec, > + .proc_handler = proc_dointvec_minmax, > .extra1 = &zero, > }, > #endif > @@ -1231,7 +1231,7 @@ static struct ctl_table vm_table[] = { > .data = &zone_reclaim_mode, > .maxlen = sizeof(zone_reclaim_mode), > .mode = 0644, > - .proc_handler = proc_dointvec, > + .proc_handler = proc_dointvec_minmax, > .extra1 = &zero, > }, > { > @@ -1287,7 +1287,7 @@ static struct ctl_table vm_table[] = { > .data = &vdso_enabled, > .maxlen = sizeof(vdso_enabled), > .mode = 0644, > - .proc_handler = proc_dointvec, > + .proc_handler = proc_dointvec_minmax, > .extra1 = &zero, > }, > #endif
| |