Messages in this thread | | | Date | Thu, 3 Mar 2011 13:05:04 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH RESEND] x86, amd-nb: Misc correctness fixes |
| |
* Borislav Petkov <bp@amd64.org> wrote:
> On Thu, Mar 03, 2011 at 04:14:40AM -0500, Ingo Molnar wrote: > > I'm confused about the title - a 'correctness fix' is one that fixes an actual bug. > > > > Did you mean 'cleanliness fixes'? > > Yes sir, this is basically a result from the 'make W=1 ..' thing I've > been playing with lately. Fixed. > > > Also, checkpatch outputs a warning that looks legit. > > Won't happen again. Hadn't enabled the pre-commit hook for checkpatch on > that machine. Fixed.
Note that there are checkpatch warnings that are crappy - especially the col80 ones tend to produce 'fixes' that are far worse than the offense. So it's not an automatism, it's a case by case tool.
> Here's a better version:
Applied, thanks!
Ingo
| |