Messages in this thread | | | Date | Thu, 3 Mar 2011 11:52:42 +0000 | From | Russell King - ARM Linux <> | Subject | Re: [PATCHv1] ARM: imx: Add support for low power suspend on MX51. |
| |
On Wed, Mar 02, 2011 at 10:52:38PM +0100, Uwe Kleine-König wrote: > > +static int __init mx5_pm_init(void) > > +{ > > + if (cpu_is_mx51()) > > + suspend_set_ops(&mx5_suspend_ops); > I'd prefer to have that called by imx51_init_early.
This function name looks fine. As we now have an init_early in the arch hooks, let's keep things called foo_init_early() to that use and not start using 'early' for stuff used from initcalls.
Renaming this is a recipe for causing confusion and having grep hit false positives. Please leave it as is. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |