lkml.org 
[lkml]   [2011]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] [PATCH 5/10] Generic Watchdog Timer Driver
Hi Alexander,

> On Wednesday 23 February 2011, 21:43:30 Wim Van Sebroeck wrote:
> > commit 1959ea403c69af855f5cd13e5c9b33123d2137b2
> > Author: Wim Van Sebroeck <wim@iguana.be>
> > Date: Fri Jun 18 09:45:49 2010 +0000
> >
> > watchdog: WatchDog Timer Driver Core - Part 5
> >
> > This part add's the WDIOC_SETTIMEOUT and WDIOC_GETTIMEOUT ioctl
> > functionality to the WatchDog Timer Driver Core framework.
> >
> > Signed-off-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
> > Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
> >
> > [snip]
>
> Any specific reason you can only specify seconds as timeout? There is no way
> to set a timeout of e.g. 500ms or 1500ms.
> You can change this by using using a struct timeval for setting a timeout.
> What do you think?

1) The current ioctl call is like this in all drivers. So changing it would break things.
2) Is there a real need for having 500ms or 1500ms? why would 1 or 2 seconds not be OK? (which are allready small timeouts for userspace anyway...)

Kind regards,
Wim.



\
 
 \ /
  Last update: 2011-03-03 11:41    [W:0.910 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site