lkml.org 
[lkml]   [2011]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tip:core/urgent] WARN_ON_SMP(): Add comment to explain ({0;})

* Alexey Dobriyan <adobriyan@gmail.com> wrote:

> On Mon, Mar 28, 2011 at 11:09:00AM -0400, Steven Rostedt wrote:
> > Geeze, I never expected such a fuss over a simple change ;)
>
> And it's still broken ;-)
>
> WARN_ON_SMP(x) should expand to x, not 0.

Dunno, we really do not want to *guarantee* side-effects in WARN_ON()
constructs.

Thanks,

Ingo


\
 
 \ /
  Last update: 2011-03-29 09:33    [W:0.640 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site