lkml.org 
[lkml]   [2011]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] bitmap, irq: Add smp_affinity_list interface to /proc/irq
On Tue, 29 Mar 2011 16:56:12 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:

> On Tue, 29 Mar 2011 16:46:52 -0700
> Mike Travis <travis@sgi.com> wrote:
>
> > + /* create /proc/irq/<irq>/smp_affinity_list */
> > + proc_create_data("smp_affinity_list", 0600, desc->dir,
> > + &irq_affinity_list_proc_fops, (void *)(long)irq);
>
> Always document your interfaces, please. `grep -r smp_affinity
> Documentation' shows where.
>
> And one we've seen a description of the proposed new interface, we can
> review the patch!

Also, the patch adds a new interface which duplicates an existing one,
only the formats are different, yes? This is, of course, bad.

The only justification we've seen for being bad is "Manually adjusting
the smp_affinity for IRQ's becomes unwieldy when the cpu count is
large". A more thorough description of how painful this is might help
motivate people to do bad things to the kernel.

Also, if it's just a matter of an alternative presentation of the data,
why not implement the desired user interface with a little userspace
tool then feed the results down into the existing kernel interface?



\
 
 \ /
  Last update: 2011-03-30 02:45    [W:0.099 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site