lkml.org 
[lkml]   [2011]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 08/23] fujitsu-laptop: Convert printks to pr_<level>
Date
> Added pr_fmt, converted printks and removed hard coded prefixes.
>
> Signed-off-by: Joe Perches <joe@perches.com>

Acked-by: Jonathan Woithe <jwoithe@physics.adelaide.edu.au>

But see comment below.

OOI, what does pr_*() give us over printk()? I presume it makes it easier
to selectively remove certain printk levels from the kernel image in the
name of size reduction.

> diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
> index 493054c..6b26666 100644
> --- a/drivers/platform/x86/fujitsu-laptop.c
> +++ b/drivers/platform/x86/fujitsu-laptop.c
> :
> @@ -907,8 +907,8 @@ static int acpi_fujitsu_hotkey_add(struct acpi_device *device)
> if (result == 0) {
> fujitsu_hotkey->logolamp_registered = 1;
> } else {
> - printk(KERN_ERR "fujitsu-laptop: Could not register "
> - "LED handler for logo lamp, error %i\n", result);
> + pr_err("Could not register LED handler for logo lamp, error %i\n",
> + result);
> }
> }
>
> @@ -919,8 +919,8 @@ static int acpi_fujitsu_hotkey_add(struct acpi_device *device)
> if (result == 0) {
> fujitsu_hotkey->kblamps_registered = 1;
> } else {
> - printk(KERN_ERR "fujitsu-laptop: Could not register "
> - "LED handler for keyboard lamps, error %i\n", result);
> + pr_err("Could not register LED handler for keyboard lamps, error %i\n",
> + result);
> }
> }
> #endif

Some people *may* insist that these long (>80 character) pr_err() lines be
split so they remain <80 in length. This was the reason why the original
printk() call was split like it was.

Regards
jonathan


\
 
 \ /
  Last update: 2011-03-30 00:49    [W:0.295 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site