Messages in this thread | | | Date | Tue, 29 Mar 2011 09:18:04 -0700 | From | Randy Dunlap <> | Subject | Re: [PATCH] Fix build failure when CONFIG_NLS is set to 'm' by allmodconfig |
| |
On 03/28/11 18:55, OGAWA Hirofumi wrote: > Randy Dunlap <randy.dunlap@oracle.com> writes: > >>> I don't get this.. you should not be getting CONFIG_NLS=m unless you >>> have stripped you config files really.. :-) Is it possible to get >>> your .config to hit this issue. >> >> I haven't stripped any config files -- but they are randconfig files. >> Two (2) config files that cause build failures are attached. > > config PCI_IOAPIC > bool > depends on PCI > depends on ACPI > depends on HOTPLUG > default y > > select NLS if (DMI || ACPI)
Ugh. That looks seriously mucked up. Dell people, have you checked what it is linux-next for this pci-label stuff?
Jesse, I would drop the b0rked pieces and ask for a new patch.
> I guess this is simply wrong. It will be parsed as > > config PCI_IOAPIC > bool > depends on PCI > depends on ACPI > depends on HOTPLUG > default y > select NLS if (DMI || ACPI) > > How about something like the following? > > config PCI_LABEL > bool > select NLS > depends on (DMI || ACPI)
What sets/enables it then? or did you mean: def_bool y and in that case, should it be a user-visible & user-changeable kconfig option?
-- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***
| |