Messages in this thread | | | Date | Mon, 28 Mar 2011 09:35:42 +0200 | From | Tejun Heo <> | Subject | Re: [PATCH] slub: Disable the lockless allocator |
| |
Hello,
Heh, a lot of activities over the weekend.
On Mon, Mar 28, 2011 at 09:12:24AM +0300, Pekka Enberg wrote: > >@@ -37,13 +43,13 @@ > > pushf > > cli > > > >- cmpq %gs:(%rsi), %rax > >+ cmpq SEG_PREFIX(%rsi), %rax > > jne not_same > >- cmpq %gs:8(%rsi), %rdx > >+ cmpq SEG_PREFIX 8(%rsi), %rdx > > jne not_same > > > >- movq %rbx, %gs:(%rsi) > >- movq %rcx, %gs:8(%rsi) > >+ movq %rbx, SEG_PREFIX(%rsi) > >+ movq %rcx, SEG_PREFIX 8(%rsi) > > > > popf > > mov $1, %al > > Tejun, does this look good to you as well? I think it should go > through the percpu tree. It's needed to fix a boot crash with > lockless SLUB fastpaths enabled.
Linus already applied it so it's all done now. The patch looks okay to me although I would like to have the SEG_PREFIX defined in asm/percpu.h instead. Well, we can do that later.
Thanks.
-- tejun
| |