Messages in this thread Patch in this message | | | Date | Tue, 29 Mar 2011 06:18:04 +0300 | From | Dan Carpenter <> | Subject | [patch] [SCSI] tcm_loop: off by one in tcm_loop_make_naa_tpg() |
| |
This is an off by one that could result in memory corruption.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/target/loopback/tcm_loop.c b/drivers/target/loopback/tcm_loop.c index aed4e46..2bb5062 100644 --- a/drivers/target/loopback/tcm_loop.c +++ b/drivers/target/loopback/tcm_loop.c @@ -1239,7 +1239,7 @@ struct se_portal_group *tcm_loop_make_naa_tpg( tpgt_str += 5; /* Skip ahead of "tpgt_" */ tpgt = (unsigned short int) simple_strtoul(tpgt_str, &end_ptr, 0); - if (tpgt > TL_TPGS_PER_HBA) { + if (tpgt >= TL_TPGS_PER_HBA) { printk(KERN_ERR "Passed tpgt: %hu exceeds TL_TPGS_PER_HBA:" " %u\n", tpgt, TL_TPGS_PER_HBA); return ERR_PTR(-EINVAL);
| |