lkml.org 
[lkml]   [2011]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [V9fs-developer] [PATCH 1/5] fs/9p: Fix revalidate to return correct value
    On 03/25/2011 01:50 PM, Venkateswararao Jujjuri wrote:
    > On 03/25/2011 04:30 AM, Aneesh Kumar K.V wrote:
    >> revalidate should return> 0 on success.
    >>
    >> Signed-off-by: Aneesh Kumar K.V<aneesh.kumar@linux.vnet.ibm.com>
    >
    > Reviewed-by: Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>
    >
    >> ---
    >> fs/9p/vfs_dentry.c | 2 +-
    >> 1 files changed, 1 insertions(+), 1 deletions(-)
    >>
    >> diff --git a/fs/9p/vfs_dentry.c b/fs/9p/vfs_dentry.c
    >> index b6a3b9f..59c5ddc 100644
    >> --- a/fs/9p/vfs_dentry.c
    >> +++ b/fs/9p/vfs_dentry.c
    >> @@ -126,7 +126,7 @@ static int v9fs_lookup_revalidate(struct dentry
    >> *dentry, struct nameidata *nd)
    >> retval = v9fs_refresh_inode_dotl(fid, inode);
    >> else
    >> retval = v9fs_refresh_inode(fid, inode);
    >> - if (retval<= 0)
    >> + if (retval< 0)
    This change is causing tuxera rename test failure with acls enabled.

    /root/pjd-fstest-20080816/tests/rename/10.t (Wstat: 0 Tests: 188 Failed: 6)
    Failed tests: 65, 71, 74, 77, 79-80
    The comment in namei says:
    " If d_revalidate returned 0 attempt to invalidate the dentry
    otherwise d_revalidate is asking us
    to return a fail status." I guess we need to return 0 in the case of
    rename.
    Need more closer look at this patch.

    - JV



    >> return retval;
    >> }
    >> out_valid:
    >



    \
     
     \ /
      Last update: 2011-03-28 22:51    [W:0.025 / U:62.168 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site