lkml.org 
[lkml]   [2011]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6/6] nommu: fix a compile warning in do_mmap_pgoff()
    Date
    Because 'ret' is declared as int, not unsigned long, no need to cast the
    error contants into unsigned long. If you compile this code on a 64-bit
    machine somehow, you'll see following warning:

    CC mm/nommu.o
    mm/nommu.c: In function ‘do_mmap_pgoff’:
    mm/nommu.c:1411: warning: overflow in implicit constant conversion

    Signed-off-by: Namhyung Kim <namhyung@gmail.com>
    ---
    mm/nommu.c | 6 +++---
    1 files changed, 3 insertions(+), 3 deletions(-)

    diff --git a/mm/nommu.c b/mm/nommu.c
    index 662fd46449a6..c7af249076ac 100644
    --- a/mm/nommu.c
    +++ b/mm/nommu.c
    @@ -1400,15 +1400,15 @@ unsigned long do_mmap_pgoff(struct file *file,
    if (capabilities & BDI_CAP_MAP_DIRECT) {
    addr = file->f_op->get_unmapped_area(file, addr, len,
    pgoff, flags);
    - if (IS_ERR((void *) addr)) {
    + if (IS_ERR_VALUE(addr)) {
    ret = addr;
    - if (ret != (unsigned long) -ENOSYS)
    + if (ret != -ENOSYS)
    goto error_just_free;

    /* the driver refused to tell us where to site
    * the mapping so we'll have to attempt to copy
    * it */
    - ret = (unsigned long) -ENODEV;
    + ret = -ENODEV;
    if (!(capabilities & BDI_CAP_MAP_COPY))
    goto error_just_free;

    --
    1.7.4
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-03-28 15:59    [W:0.023 / U:0.036 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site