Messages in this thread | | | Date | Mon, 28 Mar 2011 22:45:40 +0900 | From | Minchan Kim <> | Subject | Re: [PATCH] memcg: fix mem_cgroup_rotate_reclaimable_page |
| |
On Mon, Mar 28, 2011 at 02:51:46PM +0200, Eric Dumazet wrote: > Le mardi 22 février 2011 à 00:59 +0900, Minchan Kim a écrit : > > Fixed version. > > > > From be7d31f6e539bbad1ebedf52c6a51a4a80f7976a Mon Sep 17 00:00:00 2001 > > From: Minchan Kim <minchan.kim@gmail.com> > > Date: Tue, 22 Feb 2011 00:53:05 +0900 > > Subject: [PATCH v7 2/3] memcg: move memcg reclaimable page into tail of inactive list > > > > The rotate_reclaimable_page function moves just written out > > pages, which the VM wanted to reclaim, to the end of the > > inactive list. That way the VM will find those pages first > > next time it needs to free memory. > > This patch apply the rule in memcg. > > It can help to prevent unnecessary working page eviction of memcg. > > > > Acked-by: Balbir Singh <balbir@linux.vnet.ibm.com> > > Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > > Reviewed-by: Rik van Riel <riel@redhat.com> > > Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> > > Cc: Johannes Weiner <hannes@cmpxchg.org> > > Signed-off-by: Minchan Kim <minchan.kim@gmail.com> > > --- > > Hmm... "inline inline" is an error on some gcc versions > > CC arch/x86/kernel/asm-offsets.s > In file included from include/linux/swap.h:8, > from include/linux/suspend.h:4, > from arch/x86/kernel/asm-offsets.c:12: > include/linux/memcontrol.h:220: error: duplicate `inline' > make[1]: *** [arch/x86/kernel/asm-offsets.s] Error 1 > > > > +static inline inline void mem_cgroup_rotate_reclaimable_page(struct page *page) > > +{ > > + return ; > > +} > > + > > [PATCH] memcg: fix mem_cgroup_rotate_reclaimable_page proto > > commit 3f58a8294333 (move memcg reclaimable page into tail of inactive > list) added inline keyword twice in its prototype. > > Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> > Cc: Minchan Kim <minchan.kim@gmail.com> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Balbir Singh <balbir@linux.vnet.ibm.com> > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> > Cc: Johannes Weiner <hannes@cmpxchg.org> Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
It a was totally my fault. Thanks very much. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |