Messages in this thread | | | Date | Fri, 25 Mar 2011 18:43:03 -0700 | From | Randy Dunlap <> | Subject | Re: [PATCH] watchdog: fix nv_tco section mismatch |
| |
On 03/25/11 16:42, Mike Waychison wrote: > On Thu, Mar 24, 2011 at 1:32 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote: >> From: Randy Dunlap <randy.dunlap@oracle.com> >> >> Fix section mismatch warning: >> Mark the called nv_tco_getdevice() as __devinit, just like its caller. > > This looks fine. > > I can't seem to reproduce the warning on my end however, compiling > this as a built-in nor as a module. How do I trigger a difference > between __init and __devinit?
I just used allmodconfig. But why wouldn't you see a differnence between __init and __devinit? They are defined differently in include/linux/init.h, but maybe on some $arch, those sections are treated differently?
I dunno.
-- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***
| |