Messages in this thread Patch in this message | | | Date | Fri, 25 Mar 2011 16:44:15 -0700 | From | Greg KH <> | Subject | [39/63] USB: Do not pass negative length to snoop_urb() |
| |
2.6.38-stable review patch. If anyone has any objections, please let us know.
------------------
From: Michal Sojka <sojkam1@fel.cvut.cz>
commit 9d02b42614149ebccf12c9c580601ed01bd83070 upstream.
When `echo Y > /sys/module/usbcore/parameters/usbfs_snoop` and usb_control_msg() returns error, a lot of kernel memory is dumped to dmesg until unhandled kernel paging request occurs.
Signed-off-by: Michal Sojka <sojkam1@fel.cvut.cz> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
--- drivers/usb/core/devio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/usb/core/devio.c +++ b/drivers/usb/core/devio.c @@ -802,7 +802,7 @@ static int proc_control(struct dev_state tbuf, ctrl.wLength, tmo); usb_lock_device(dev); snoop_urb(dev, NULL, pipe, max(i, 0), min(i, 0), COMPLETE, - tbuf, i); + tbuf, max(i, 0)); if ((i > 0) && ctrl.wLength) { if (copy_to_user(ctrl.data, tbuf, i)) { free_page((unsigned long)tbuf);
| |