lkml.org 
[lkml]   [2011]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv3] usb: core: Change usb_create_sysfs_intf_files()' return type to void
On Fri, 25 Mar 2011, Michal Nazarewicz wrote:

> The usb_create_sysfs_intf_files() function always returned zero even
> if it failed to create sysfs fails. Since this is a desired behaviour
> there is no need to return return code at all. This commit changes
> function's return type (form int) to void.
>
> Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
> Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> ---
> drivers/usb/core/sysfs.c | 13 +++++--------
> drivers/usb/core/usb.c | 3 +--
> drivers/usb/core/usb.h | 2 +-
> 3 files changed, 7 insertions(+), 11 deletions(-)
>
> On Fri, 25 Mar 2011 16:33:12 +0100, Alan Stern <stern@rowland.harvard.edu> wrote:
> > My style preference is to put the empty statement before the comment.
> > It's unusual to have a comment appearing before a statement on the same
> > line. For example:
> > ; /* We don't care if the function fails */
>
> Changed. And I agree, it looks better now. :)

Acked-by: Alan Stern <stern@rowland.harvard.edu>



\
 
 \ /
  Last update: 2011-03-25 18:05    [W:0.053 / U:1.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site