Messages in this thread |  | | Date | Thu, 24 Mar 2011 09:31:20 +0100 | From | Wim Van Sebroeck <> | Subject | Re: [PATCH -v3 -resend] watchdog, SP5100: Check if firmware has set correct value in tcobase. |
| |
Hi Yinghai,
> Stefano found SP5100 TCO watchdog driver using wrong address. > > [ 9.148536] SP5100 TCO timer: SP5100 TCO WatchDog Timer Driver v0.01 > [ 9.148628] DEBUG __ioremap_caller WARNING address=b8fe00 size=8 valid=1 reserved=1 > > and e820 said that range is RAM. > > We should check if we can use that reading out. BIOS could just program wrong address there. > > -v2: Mike pointed out one path need one release. > -v3: corrected logic checking with request_mem_region_exclusive() > Found by Konrad. > > > Reported-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> > Signed-off-by:Yinghai Lu <yinghai@kernel.org> > Acked-by: Mike Waychison <mikew@google.com> > Tested-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
This patch is in linux-2.6-watchdog-next for a week now. Will go upstream to linus.
Kind regards, Wim.
|  |